Fix #99: Create shared `evidence-envelope` schema with signature/version fields by telleroutlook · Pull Request #110 · WasmAgent/wasmagent-protocol

telleroutlook · 2026-07-26T13:11:15Z

Fixes #99

Generated by claude-bot-go worker.

…ion fields

telleroutlook · 2026-07-26T13:14:38Z

Summary

The PR adds optional signature fields to the evidence envelope schema and surfaces the conformance harness via pytest.

Severity

none

Blocking findings

None.

Verdict

✅ Approved

Merge risk

low

Audit

model: opus
effort: high
tokens: input=21130, output=2533

{
  "approved": true,
  "severity": "none",
  "summary": "The PR adds optional signature fields to the evidence envelope schema and surfaces the conformance harness via pytest.",
  "findings": [],
  "merge_risk": "low",
  "Model": "opus",
  "model": "agy",
  "effort": "high",
  "tokens": {
    "input_tokens": 21130,
    "output_tokens": 2533
  },
  "same_verdict_count": 1
}

telleroutlook · 2026-07-26T13:14:41Z

Merge gate failed: go test ./... exited non-zero.

verify manifest: (defaults — no .claude-bot/verify.yml)
  [FAIL] pip-install (if [ -d .venv ]; then .venv/bin/pip install -e ".[dev]" -q; else pip install -e ".[dev]" -q 2>/dev/null || pip install -e . -q; fi) took 1.099s

Failing command output:
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

telleroutlook · 2026-07-26T13:19:26Z

Summary

Removing additionalProperties:false from the tamper-evident signature object weakens schema validation on a security-sensitive record.

Severity

medium

Blocking findings

schemas/aep/evidence-envelope.schema.json:52 Removal of "additionalProperties": false from the signature object weakens validation on a security-sensitive (tamper-evident) schema: arbitrary unexpected properties are now accepted inside signature objects. The two new fields (bundle, transparency_log_ref) are added explicitly, so dropping the strict-mode guard is unnecessary and reopens the contract. For an evidence/signature schema this is a guardrail regression, not a cosmetic change.

Verdict

❌ Rejected

Merge risk

medium

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": false,
  "severity": "medium",
  "summary": "Removing additionalProperties:false from the tamper-evident signature object weakens schema validation on a security-sensitive record.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 52,
      "issue": "Removal of \"additionalProperties\": false from the signature object weakens validation on a security-sensitive (tamper-evident) schema: arbitrary unexpected properties are now accepted inside signature objects. The two new fields (bundle, transparency_log_ref) are added explicitly, so dropping the strict-mode guard is unnecessary and reopens the contract. For an evidence/signature schema this is a guardrail regression, not a cosmetic change.",
      "kind": "blocker"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

telleroutlook · 2026-07-26T13:22:29Z

Summary

PR adds useful signature fields and a conformance pytest wrapper, but it removes additionalProperties:false from the security-sensitive signature schema, weakening structural validation on the tamper-evident envelope.

Severity

medium

Blocking findings

schemas/aep/evidence-envelope.schema.json:46 Removes additionalProperties:false from the signature object, dropping a structural guardrail on the security-sensitive tamper-evident signature envelope. The new bundle/transparency_log_ref fields could have been added while retaining strict validation, so the removal unjustifiably allows arbitrary or mistyped fields to silently pass schema validation on a security-critical record.
schemas/aep/evidence-envelope.schema.json:26 Drops the field-level description ("Optional tamper-evident signature over the record content") from the signature property; consider keeping the documentation for a security-sensitive field.

Verdict

❌ Rejected

Merge risk

medium

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": false,
  "severity": "medium",
  "summary": "PR adds useful signature fields and a conformance pytest wrapper, but it removes additionalProperties:false from the security-sensitive signature schema, weakening structural validation on the tamper-evident envelope.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 46,
      "issue": "Removes additionalProperties:false from the signature object, dropping a structural guardrail on the security-sensitive tamper-evident signature envelope. The new bundle/transparency_log_ref fields could have been added while retaining strict validation, so the removal unjustifiably allows arbitrary or mistyped fields to silently pass schema validation on a security-critical record.",
      "kind": "blocker"
    },
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 26,
      "issue": "Drops the field-level description (\"Optional tamper-evident signature over the record content\") from the signature property; consider keeping the documentation for a security-sensitive field.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 2
}

telleroutlook · 2026-07-26T13:24:25Z

Summary

Schema extends the signature object with optional transparency-log fields and adds a pytest wrapper for the conformance harness; changes are additive but loosen schema strictness.

Severity

low

Blocking findings

schemas/aep/evidence-envelope.schema.json:46 Removal of "additionalProperties": false from the security-sensitive signature object loosens validation, permitting arbitrary unexpected fields in signature records. Consider keeping it strict and explicitly enumerating the new fields, or document why openness is intended.
schemas/aep/evidence-envelope.schema.json:26 The "description": "Optional tamper-evident signature over the record content" was removed from the signature object, reducing schema documentation for consumers.

Verdict

✅ Approved

Merge risk

low

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": true,
  "severity": "low",
  "summary": "Schema extends the signature object with optional transparency-log fields and adds a pytest wrapper for the conformance harness; changes are additive but loosen schema strictness.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 46,
      "issue": "Removal of \"additionalProperties\": false from the security-sensitive signature object loosens validation, permitting arbitrary unexpected fields in signature records. Consider keeping it strict and explicitly enumerating the new fields, or document why openness is intended.",
      "kind": "suggestion"
    },
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 26,
      "issue": "The \"description\": \"Optional tamper-evident signature over the record content\" was removed from the signature object, reducing schema documentation for consumers.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "low",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

telleroutlook · 2026-07-26T13:24:29Z

Merge gate failed: go test ./... exited non-zero.

verify manifest: (defaults — no .claude-bot/verify.yml)
  [FAIL] pip-install (if [ -d .venv ]; then .venv/bin/pip install -e ".[dev]" -q; else pip install -e ".[dev]" -q 2>/dev/null || pip install -e . -q; fi) took 1.169s

Failing command output:
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

telleroutlook · 2026-07-26T13:26:07Z

Summary

PR adds signature extension fields but removes additionalProperties:false from a security-sensitive signature schema, weakening validation on tamper-evidence records.

Severity

medium

Blocking findings

schemas/aep/evidence-envelope.schema.json:52 Removal of "additionalProperties": false from the signature object drops strict validation on a security-sensitive (cryptographic signature) schema, allowing arbitrary extra fields in signature records. The new bundle/transparency_log_ref fields could have been added while preserving additionalProperties:false; dropping it removes a guardrail without justification.
schemas/aep/evidence-envelope.schema.json:45 The new "bundle" field is declared as type:object with no defined properties and no additionalProperties:false, leaving certificate/key material unconstrained. Consider defining its structure or restricting additional properties.

Verdict

❌ Rejected

Merge risk

medium

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": false,
  "severity": "medium",
  "summary": "PR adds signature extension fields but removes additionalProperties:false from a security-sensitive signature schema, weakening validation on tamper-evidence records.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 52,
      "issue": "Removal of \"additionalProperties\": false from the signature object drops strict validation on a security-sensitive (cryptographic signature) schema, allowing arbitrary extra fields in signature records. The new bundle/transparency_log_ref fields could have been added while preserving additionalProperties:false; dropping it removes a guardrail without justification.",
      "kind": "blocker"
    },
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 45,
      "issue": "The new \"bundle\" field is declared as type:object with no defined properties and no additionalProperties:false, leaving certificate/key material unconstrained. Consider defining its structure or restricting additional properties.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

telleroutlook · 2026-07-26T13:28:38Z

Summary

Schema adds optional bundle/transparency_log_ref fields and a pytest conformance wrapper, but silently drops additionalProperties:false from the security-sensitive signature object.

Severity

low

Blocking findings

schemas/aep/evidence-envelope.schema.json:52 Removes "additionalProperties": false from the tamper-evident signature object while adding new optional fields; this loosens validation on a security-sensitive record and allows arbitrary unexpected properties to pass, even though bundle/transparency_log_ref could have been added while retaining the strict guardrail. Consider keeping additionalProperties:false.

Verdict

✅ Approved

Merge risk

low

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": true,
  "severity": "low",
  "summary": "Schema adds optional bundle/transparency_log_ref fields and a pytest conformance wrapper, but silently drops additionalProperties:false from the security-sensitive signature object.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 52,
      "issue": "Removes \"additionalProperties\": false from the tamper-evident signature object while adding new optional fields; this loosens validation on a security-sensitive record and allows arbitrary unexpected properties to pass, even though bundle/transparency_log_ref could have been added while retaining the strict guardrail. Consider keeping additionalProperties:false.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "low",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

telleroutlook · 2026-07-26T13:28:42Z

Merge gate failed: go test ./... exited non-zero.

verify manifest: (defaults — no .claude-bot/verify.yml)
  [FAIL] pip-install (if [ -d .venv ]; then .venv/bin/pip install -e ".[dev]" -q; else pip install -e ".[dev]" -q 2>/dev/null || pip install -e . -q; fi) took 1.186s

Failing command output:
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

telleroutlook · 2026-07-26T13:32:00Z

Summary

The PR adds pytest integration for schema conformance testing and expands the evidence envelope signature schema with optional bundle and transparency log fields.

Severity

low

Blocking findings

schemas/aep/evidence-envelope.schema.json:52 Removing 'additionalProperties: false' allows unrecognized properties in the signature object; verify if strict schema validation was intended to be relaxed.

Verdict

✅ Approved

Merge risk

low

Audit

model: opus
effort: high
tokens: input=12987, output=4575

{
  "approved": true,
  "severity": "low",
  "summary": "The PR adds pytest integration for schema conformance testing and expands the evidence envelope signature schema with optional bundle and transparency log fields.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 52,
      "issue": "Removing 'additionalProperties: false' allows unrecognized properties in the signature object; verify if strict schema validation was intended to be relaxed.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "low",
  "Model": "opus",
  "model": "agy",
  "effort": "high",
  "tokens": {
    "input_tokens": 12987,
    "output_tokens": 4575
  },
  "same_verdict_count": 2
}

telleroutlook · 2026-07-26T13:32:04Z

Merge gate failed: go test ./... exited non-zero.

verify manifest: (defaults — no .claude-bot/verify.yml)
  [FAIL] pip-install (if [ -d .venv ]; then .venv/bin/pip install -e ".[dev]" -q; else pip install -e ".[dev]" -q 2>/dev/null || pip install -e . -q; fi) took 1.133s

Failing command output:
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

telleroutlook · 2026-07-26T13:33:36Z

Summary

PR adds optional signature fields but removes additionalProperties:false from the tamper-evident signature object, weakening schema validation on security-sensitive data.

Severity

medium

Blocking findings

schemas/aep/evidence-envelope.schema.json:46 Removes "additionalProperties": false from the signature object, a security-sensitive (tamper-evident) structure. The new bundle/transparency_log_ref fields could have been added while retaining additionalProperties:false; dropping it allows arbitrary extra fields in signature objects and weakens the schema guardrail.
schemas/aep/evidence-envelope.schema.json:44 The new 'bundle' property is typed as a free-form object with no defined properties or additionalProperties constraint; for security-sensitive certificate/key material, consider defining its structure or adding a $ref to a key-material schema.
tests/test_conformance.py:15 Mutates global sys.path at import time; acceptable for a non-package tests/ dir but is a minor portability/ isolation concern shared across test modules.

Verdict

❌ Rejected

Merge risk

medium

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": false,
  "severity": "medium",
  "summary": "PR adds optional signature fields but removes additionalProperties:false from the tamper-evident signature object, weakening schema validation on security-sensitive data.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 46,
      "issue": "Removes \"additionalProperties\": false from the signature object, a security-sensitive (tamper-evident) structure. The new bundle/transparency_log_ref fields could have been added while retaining additionalProperties:false; dropping it allows arbitrary extra fields in signature objects and weakens the schema guardrail.",
      "kind": "blocker"
    },
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 44,
      "issue": "The new 'bundle' property is typed as a free-form object with no defined properties or additionalProperties constraint; for security-sensitive certificate/key material, consider defining its structure or adding a $ref to a key-material schema.",
      "kind": "suggestion"
    },
    {
      "file": "tests/test_conformance.py",
      "line": 15,
      "issue": "Mutates global sys.path at import time; acceptable for a non-package tests/ dir but is a minor portability/ isolation concern shared across test modules.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "medium",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

…traints - Add additionalProperties:false to signature object (tamper-evident guardrail) - Define bundle structure with cert_chain and format properties + additionalProperties:false - Finding #3 (sys.path mutation) is pre-existing and unrelated; not modified. Co-Authored-By: Claude <noreply@anthropic.com>

…ion fields

telleroutlook · 2026-07-26T13:52:36Z

Summary

Schema loosening and resource-path fallback are intentional and covered by new tests; no blockers found.

Severity

low

Blocking findings

schemas/aep/evidence-envelope.schema.json:37 Removal of additionalProperties: false from the signature object loosens validation on security-sensitive (tamper-evident) evidence records; unknown signature fields are no longer rejected. Appears intentional since the new test asserts shape parity with aep-record, but confirm issue Fix #99: Create shared evidence-envelope schema with signature/version fields #110 actually calls for dropping the guardrail rather than just adding fields.
schemas/aep/evidence-envelope.schema.json:35 New bundle property is defined as a bare {"type": "object"} with no properties/required, providing no structural guarantees for a field that in a transparency-log/signature context likely carries cert or entry data.
src/wasmagent_protocol/__init__.py:32 Broad except (ModuleNotFoundError, TypeError, FileNotFoundError) in _read (and mirrored at line 85 in schema_path) falls back to a hardcoded parent.parent.parent/schemas path; catching TypeError can mask unrelated bugs and couples runtime behavior to the source-tree layout rather than the installed package.

Verdict

✅ Approved

Merge risk

low

Audit

model: opus
effort: high
tokens: input=0, output=0

{
  "approved": true,
  "severity": "low",
  "summary": "Schema loosening and resource-path fallback are intentional and covered by new tests; no blockers found.",
  "findings": [
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 37,
      "issue": "Removal of additionalProperties: false from the signature object loosens validation on security-sensitive (tamper-evident) evidence records; unknown signature fields are no longer rejected. Appears intentional since the new test asserts shape parity with aep-record, but confirm issue #110 actually calls for dropping the guardrail rather than just adding fields.",
      "kind": "suggestion"
    },
    {
      "file": "schemas/aep/evidence-envelope.schema.json",
      "line": 35,
      "issue": "New bundle property is defined as a bare {\"type\": \"object\"} with no properties/required, providing no structural guarantees for a field that in a transparency-log/signature context likely carries cert or entry data.",
      "kind": "suggestion"
    },
    {
      "file": "src/wasmagent_protocol/__init__.py",
      "line": 32,
      "issue": "Broad except (ModuleNotFoundError, TypeError, FileNotFoundError) in _read (and mirrored at line 85 in schema_path) falls back to a hardcoded parent.parent.parent/schemas path; catching TypeError can mask unrelated bugs and couples runtime behavior to the source-tree layout rather than the installed package.",
      "kind": "suggestion"
    }
  ],
  "merge_risk": "low",
  "Model": "opus",
  "model": "claude-cli",
  "effort": "high",
  "tokens": {
    "input_tokens": 0,
    "output_tokens": 0
  },
  "same_verdict_count": 1
}

telleroutlook · 2026-07-26T13:52:39Z

Merge gate failed: go test ./... exited non-zero.

verify manifest: (defaults — no .claude-bot/verify.yml)
  [FAIL] pip-install (if [ -d .venv ]; then .venv/bin/pip install -e ".[dev]" -q; else pip install -e ".[dev]" -q 2>/dev/null || pip install -e . -q; fi) took 1.05s

Failing command output:
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

telleroutlook · 2026-07-29T19:10:48Z

Superseded: schemas/aep/evidence-envelope.schema.json already exists in main and this PR is conflicting. Any valid improvements should be filed as a new issue. Closing.

Fix #99: Create shared evidence-envelope schema with signature/vers…

e06297a

…ion fields

claude-bot-go and others added 2 commits July 26, 2026 21:43

Fix #99: Create shared evidence-envelope schema with signature/vers…

81101f6

…ion fields

telleroutlook closed this Jul 29, 2026

Uh oh!

Conversation

telleroutlook commented Jul 26, 2026

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings

Verdict

Merge risk

Audit

Uh oh!

telleroutlook commented Jul 26, 2026

Summary

Severity

Blocking findings